testiso: improve error when QEMU is terminated #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add helpers to `QemuInstance` and the underlying `ExecCmd` for querying whether the process was terminated by a signal.
Right now when QEMU gets killed during a testiso run, the error is:
FAIL: pxe-offline-install (bios + metal) (1m10.277s)
Got EOF from completion channel, coreos-installer-test-OK expected
This is accurate but doesn't hint well enough at the underlying cause.
Rework the two spots in which we wait for virtio-serial strings to also
check if QEMU was killed to provide a better error. E.g.:
FAIL: pxe-install (bios + metal) (34.483s)
QEMU unexpectedly exited while waiting awaiting completion: process killed
Related: coreos/fedora-coreos-tracker#1339
cgwalters
approved these changes
Nov 11, 2022
| @@ -93,6 +96,14 @@ func (cmd *ExecCmd) Kill() error { | |||
| return err | |||
| } | |||
|
|
|||
| func (cmd *ExecCmd) Signaled() bool { | |||
| if cmd.ProcessState == nil { | |||
There was a problem hiding this comment.
I suspect the Go race detector will flag this; I believe the separate goroutine that is blocking in Wait() will be the one that writes to this data. Probably hard to fix though without reworking things completely.
If we were to rework things...I think we want a single stream of events from the qemu process effectively, then we could centralize the sleep(1) thing there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when QEMU gets killed during a testiso run, the error is:
This is accurate but doesn't hint well enough at the underlying cause.
Rework the two spots in which we wait for virtio-serial strings to also
check if QEMU was killed to provide a better error. E.g.:
Related: coreos/fedora-coreos-tracker#1339