05core: order boot UUID restamp before ignition-kargs.service #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the ext4 in el9 at least has an issue where the filesystem can become corrupted if doing the UUID restamp at the same time as kargs are being written to the BLS. It's better anyway to make these kinds of invasive changes offline, so enforce that. Follow-up to 5fb5b4f ("05core: run `coreos-gpt-setup` and `ignition-ostree-uuid-boot` later").
jlebon
force-pushed
the
pr/kargs-ordering
branch
from
b30da1a to
6975c67
Compare
cgwalters
reviewed
Nov 9, 2023
| @@ -6,7 +6,9 @@ ConditionPathExists=!/run/ostree-live | |||
| # Any services looking at mounts need to order after this | |||
| # because it causes device re-probing. | |||
| After=coreos-gpt-setup.service | |||
| Before=ignition-disks.service | |||
| # This could mount the bootfs rw and the ext4 in el9 at least doesn't seem to | |||
| # like doing that in parallel with restamping the UUID | |||
There was a problem hiding this comment.
I bet https://lore.kernel.org/linux-fsdevel/[email protected]/ would have stopped this
cgwalters
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the ext4 in el9 at least has an issue where the filesystem
can become corrupted if doing the UUID restamp at the same time as kargs
are being written to the BLS. It's better anyway to make these kinds of
invasive changes offline, so enforce that.
Follow-up to 5fb5b4f ("05core: run
coreos-gpt-setupandignition-ostree-uuid-bootlater").