config: promote versionary key, rework it
#961
Conversation
The versionary FCOS script was one of the few things that differed between FCOS and RHCOS and was awkwardly attached as a hack knob to work. Now, we promote it to a proper key under the `misc` section, with support for stream-level overrides. This is prep for also using a versionary in other streams. The versionary is now part of the source config and cosa knows how to execute it if the `--versionary` argument is passed.
|
Requires: coreos/coreos-assembler#3735 |
| @@ -270,6 +269,8 @@ clouds: | |||
|
|
|||
| # OPTIONAL: miscellaneous options | |||
| misc: | |||
| # OPTIONAL: whether to use a versionary to derive version numbers | |||
There was a problem hiding this comment.
Is a versionary enough of a noun?
| # OPTIONAL: whether to use a versionary to derive version numbers | |
| # OPTIONAL: whether to use a versionary script to derive version numbers |
There was a problem hiding this comment.
I'm trying to make it become one. :) But fine to make it less cool.
| def use_versionary = pipecfg.misc?.versionary | ||
| if (stream_info.containsKey('versionary')) { | ||
| // stream override always wins | ||
| use_versionary = stream_info.versionary | ||
| } |
There was a problem hiding this comment.
i'm guessing if we used this in one other place we'd put a helper function in utils.groovy?
There was a problem hiding this comment.
Yeah, agree. I don't anticipate that need for now.
|
This needs to wait until coreos/fedora-coreos-config#2859 has made it to stable. |
or just PR the |
|
|
The |
This was moved to coreos/fedora-coreos-config: coreos/fedora-coreos-config#2859 And the pipeline now knows to use that instead: coreos/fedora-coreos-pipeline#961
This was moved to coreos/fedora-coreos-config: coreos/fedora-coreos-config#2859 And the pipeline now knows to use that instead: coreos/fedora-coreos-pipeline#961
The versionary FCOS script was one of the few things that differed between FCOS and RHCOS and was awkwardly attached as a hack knob to work.
Now, we promote it to a proper key under the
miscsection, with support for stream-level overrides. This is prep for also using a versionary in other streams.The versionary is now part of the source config and cosa knows how to execute it if the
--versionaryargument is passed.