This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
*: introduce an option UseLeaseTTL for lease manager's TTL #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
force-pushed
the
dongsu/use-lease-ttl
branch
from
90d10c4 to
9f33b77
Compare
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
20a3e96 to
3aaa1ab
Compare
dongsupark
force-pushed
the
master
branch
2 times, most recently
from
eb6872f to
365565e
Compare
* Introduce an option UseLeaseTTL. Default is false. * If UseLeaseTTL turned on, create lease manager with the TTL value. * When gRPC turned on, remove previous workaround of setting leaseTTL to a huge value. * Increase engine reconcile interval from 2 to 5 sec. Originally written by Hector Fernandez <[email protected]> Taken from https://github.com/giantswarm/fleet/tree/patch_lease_ttl
dongsupark
force-pushed
the
dongsu/use-lease-ttl
branch
from
9f33b77 to
8f9bb41
Compare
|
It turns out that this PR results in performance regressions. Nomi benchmark shows a large number of missing units, as well as a huge variation of unit start times. Until we could find out a solution, let's not merge. |
dongsupark
force-pushed
the
master
branch
6 times, most recently
from
39a99ba to
44591b0
Compare
dongsupark
force-pushed
the
master
branch
3 times, most recently
from
0132632 to
6974811
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to a huge value.
Originally written by @hectorj2f
Taken from https://github.com/giantswarm/fleet/tree/patch_lease_ttl