-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logout functionality through provider #226
base: v2
Are you sure you want to change the base?
Conversation
Seems to be an issue with the Go 1,9 build. Unclear what since it is the same PR that passed but from a different branch: |
@dlouwers Hey any updates on this? We are working on a similar use case where we need a redirect to a logout URL. |
@dlouwers is there any update on this? It looks like the Go 1.9 error causing the build to fail is:
I'm looking forward to use this feature :) |
You need to use Go 1.10+ as this was added with Go 1.10 |
Would re-running the tests be the solution (and resolve the merge conflict)? Looks like Travis CI config has been updated to Go 1.12 and Go 1.13 since the test failed: https://github.com/coreos/go-oidc/blob/v2/.travis.yml#L4. |
+1 for getting this in. |
For anyone else going around this, you can currently do something like: provider, err := oidc.NewProvider(ctx, issuer)
if err != nil {
return nil, err
}
var claims struct {
EndSessionURL string `json:"end_session_endpoint"`
}
err = provider.Claims(&claims)
if err != nil {
return nil, err
}
// ... claims.EndSessionURL is now end session URL to use You have to construct final URL yourself, but it gets you moving. |
Hello, Any updates on this? |
Replacement for #190 since I need to create more pull requests now