Update logging calls for upcoming Go 1.24 #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vet in Go 1.24 will add a new check to the printf analyzer that "reports a diagnostic for calls of the form `fmt.Printf(s)`, where `s` is a non-constant format string, with no other arguments. Such calls are nearly always a mistake as the value of `s` may contain the `%` symbol; use `fmt.Print` instead."
The Vet in Go 1.24 will add a new check to the printf analyzer that "reports a diagnostic for calls of the form `fmt.Printf(s)`, where `s` is a non-constant format string, with no other arguments. Such calls are nearly always a mistake as the value of `s` may contain the `%` symbol; use `fmt.Print` instead."
|
After these changes, ignition/internal/exec/stages/files/filesystemEntries.go Lines 285 to 295 in e6323fb |
|
@ferdnyc Thank you for your contributions! and being on top of that, would you mind just squashing both commits into 1 and including the change for internal? I think we could just do something like this wdyt? return fmt.Errorf("%s", fmt.Sprintf("Ignition encountered an internal error processing %q and must die now. Please file a bug", f.Path)) |
Hum, I don't think that nolint comment is for the format string here. It appears to be for something else. |
|
Ah, okay, well then we can just keep it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some calls to
Logger.PushPrefixandLogger.Infowere being passed a single, variable argument, rather than a format string as the first argument (as printf-style functions expect).The Vet in Go's upcoming 1.24 release has a new check that will flag these calls (which were already annotated with
// nolint:govetcomments). Rather than disabling linting, add a format-string first argument to make the calls kosher.