Two unimportant clang-analyzer fixes #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is another case of clang-analyzer not understanding the "GError rules"; it's getting confused by the `NULL` checks here and thinking that if `authority == NULL` it's possible `error == NULL` too. But it can't see into the implementation of libpolkit.
In theory, the server could have not sent this data. Add assertions to require this.
|
/retest |
Yeah ok I'm really close to changing these tests into something we maybe just run on release commits or as opt in or something, the bodhi error rate is extremely high. |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysroot: Silence clang-analyzer warning
I think this is another case of clang-analyzer not understanding
the "GError rules"; it's getting confused by the
NULLchecks hereand thinking that if
authority == NULLit's possibleerror == NULLtoo. But it can't see into the implementation of libpolkit.
pkg-builtins: Add assertions to quiet clang-analyzer
In theory, the server could have not sent this data. Add
assertions to require this.