Extend ID Regex to support escaped quotes #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address coreruleset/coreruleset#3239.
This PR proposes to extend the regex looking for IDs to support also IDs coming with escaped quotes.
JSON log lines such as the following one are not supported:
As described in the original issue, the problem is
[id \"920480\"]
, but now as mentioned in coreruleset/coreruleset#3239 (comment), we can just extend the regex to make it flexible enough to support also this case.