This repository has been archived by the owner on Nov 26, 2022. It is now read-only.
Use cleaner approach to include ModSecurity config #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srueg
approved these changes
Feb 20, 2020
zugao
force-pushed
the
feature/cleaner-inclusion-httpd-modsecurity
branch
from
39dc31a to
fb6c3ac
Compare
zugao
force-pushed
the
feature/cleaner-inclusion-httpd-modsecurity
branch
from
fb6c3ac to
74b9b63
Compare
|
Relates to #32. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our quest to enhance maintenability we've identified that extending the Apache configuration is not as straight-forward as it could be.
These changes:
conf/httpd.confconf/extra/httpd-modsecurity.conffile that houses all the necessary configuration just for ModSecurity in a single locationI'm still not 100% happy with:
Include /etc/modsecurity.d/include.confstatement (this was probably added for technical reasons, to make the include outside of the Apacheconffolder work)/etc/modsecurity.d/include.confas such (it should probably convey "use me to include the ModSecurity configuration from Apache", but the pattern of "include" is broken here)Improvement suggestions welcome!