Skip to content

Commit

Permalink
Merge pull request #11 from coreui/fix-sidebar-slots
Browse files Browse the repository at this point in the history
fix(Sidebar): add missing slots *Footer/*Form/*Header
  • Loading branch information
xidedix authored Jul 13, 2018
2 parents c0d6749 + d709299 commit e5a24d5
Show file tree
Hide file tree
Showing 4 changed files with 34 additions and 19 deletions.
14 changes: 7 additions & 7 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@coreui/vue",
"description": "CoreUI Vue Bootstrap 4 layout components",
"version": "2.0.0-rc.0",
"version": "2.0.0-rc.1",
"license": "MIT",
"main": "dist/coreui-vue.common.js",
"module": "dist/coreui-vue.esm.js",
Expand Down Expand Up @@ -63,7 +63,7 @@
},
"devDependencies": {
"babel-core": "^6.26.3",
"babel-eslint": "^8.2.3",
"babel-eslint": "^8.2.6",
"babel-jest": "^22.4.4",
"babel-plugin-dynamic-import-node": "^1.2.0",
"babel-plugin-module-resolver": "^3.1.1",
Expand All @@ -74,7 +74,7 @@
"eslint-plugin-html": "^4.0.3",
"eslint-plugin-import": "^2.12.0",
"eslint-plugin-jest": "^21.17.0",
"eslint-plugin-prettier": "^2.6.0",
"eslint-plugin-prettier": "^2.6.2",
"eslint-plugin-vue": "^4.5.0",
"husky": "^0.14.3",
"jest": "^22.4.4",
Expand All @@ -83,18 +83,18 @@
"jest-vue-preprocessor": "^1.4.0",
"lint-staged": "^7.1.3",
"lodash": "^4.17.10",
"node-sass": "^4.9.0",
"node-sass": "^4.9.2",
"prettier": "^1.13.4",
"rollup": "^0.59.4",
"rollup-plugin-babel": "^3.0.4",
"rollup-plugin-babel": "^3.0.7",
"rollup-plugin-commonjs": "^9.1.3",
"rollup-plugin-filesize": "^1.5.0",
"rollup-plugin-json": "^3.0.0",
"rollup-plugin-license": "^0.6.0",
"rollup-plugin-license": "^0.7.0",
"rollup-plugin-node-resolve": "^3.3.0",
"rollup-plugin-replace": "^2.0.0",
"rollup-plugin-uglify": "^3.0.0",
"rollup-plugin-vue": "^4.2.0",
"rollup-plugin-vue": "^4.3.1",
"sass-loader": "^7.0.3",
"uglify-es": "^3.3.9",
"vue": "^2.5.16",
Expand Down
13 changes: 9 additions & 4 deletions src/components/Sidebar/SidebarFooter.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
/* eslint-disable */
<template>
<div></div>
<!--<div class="sidebar-footer"></div>-->
<div v-if="hasSlotDefault" class="sidebar-footer">
<slot></slot>
</div>
</template>

<script>
export default {
name: 'sidebar-footer'
name: 'sidebar-footer',
computed: {
hasSlotDefault() {
return !!this.$slots.default;
}
}
}
</script>
13 changes: 9 additions & 4 deletions src/components/Sidebar/SidebarForm.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
/* eslint-disable */
<template>
<div></div>
<!-- <div class="sidebar-form"></div> -->
<div v-if="hasSlotDefault" class="sidebar-form">
<slot></slot>
</div>
</template>
<script>
export default {
name: 'sidebar-form'
name: 'sidebar-form',
computed: {
hasSlotDefault() {
return !!this.$slots.default;
}
}
}
</script>
13 changes: 9 additions & 4 deletions src/components/Sidebar/SidebarHeader.vue
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
/* eslint-disable */
<template>
<div></div>
<!-- <div class="sidebar-header"></div> -->
<div v-if="hasSlotDefault" class="sidebar-header">
<slot></slot>
</div>
</template>
<script>
export default {
name: 'sidebar-header'
name: 'sidebar-header',
computed: {
hasSlotDefault() {
return !!this.$slots.default;
}
}
}
</script>

0 comments on commit e5a24d5

Please sign in to comment.