Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start adding typing annotations to ExactGP #2436

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Start adding typing annotations to ExactGP #2436

merged 6 commits into from
Jan 28, 2025

Conversation

chrisyeh96
Copy link
Contributor

This pull request does 3 things:

  1. It starts adding typing annotations to ExactGP.

  2. It standardize super() calls:

    # old
super(ExactGP, self).foo()

# new
super().foo()

  3. It fixes the error message in ExactGP.__call__() to clarify that it only needs train_inputs to be given. It is OK for train_outputs=None.

@gpleiss gpleiss merged commit 41f8b28 into cornellius-gp:main Jan 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpleiss gpleiss gpleiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisyeh96 @gpleiss