Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach new_covar_cache to enable JIT tracing of models after fantasization #2605

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Detach new_covar_cache to enable JIT tracing of models after fantasization #2605

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71ea41b
detach new_covar_cache to enable tracing for fantasized models
SaiAakash Nov 9, 2024
2363eba
detach only if detach_test_caches is on
SaiAakash Nov 13, 2024
9d7857f
Merge branch 'main' into fix_fantasy_model
SaiAakash Nov 19, 2024
3437156
Merge branch 'main' into fix_fantasy_model
SaiAakash Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gpytorch/models/exact_prediction_strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def get_fantasy_strategy(self, inputs, targets, full_inputs, full_targets, full_
# now update the root and root inverse
new_lt = self.lik_train_train_covar.cat_rows(fant_train_covar, fant_fant_covar)
new_root = new_lt.root_decomposition().root
new_covar_cache = new_lt.root_inv_decomposition().root
new_covar_cache = new_lt.root_inv_decomposition().root.detach()

# Expand inputs accordingly if necessary (for fantasies at the same points)
if full_inputs[0].dim() <= full_targets.dim():
Expand Down