Feat: Screening tool adjustments #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonasdoubleyou
temporarily deployed
to
user-app-feat-screening-inmhur
Jonasdoubleyou
previously approved these changes
Feb 11, 2025
| } | ||
| } | ||
| `); | ||
|
|
||
| const { |
There was a problem hiding this comment.
Might be easier to query all courses at once, then .filter on the state for the tabs?
There was a problem hiding this comment.
I guess the tricky part would be the pagination for the different states? Like, I can fetch 100 courses but if most of them are rejected it wouldn't be useful for the other tabs
There was a problem hiding this comment.
Right, or turn courseState into a state and refetch when switching tabs?
Alternatively you could also do multiple courseSearch in the same query (with a GraphQL alias)
Jonasdoubleyou
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves (partially) https://github.com/corona-school/project-user/issues/1425
What was done?
SuS / HuH-Empfehlungprefix when showing suggestions