Skip to content
This repository was archived by the owner on May 16, 2023. It is now read-only.

Registration token refactor #260

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Registration Token Refactor (Abstract Factory) style fixes
damirseit committed Feb 28, 2022
commit fe86270125c2fbdd2cb9a52a2ba94631565234d9
Original file line number Diff line number Diff line change
@@ -102,9 +102,9 @@ public DeferredResult<ResponseEntity<RegistrationToken>> generateRegistrationTok

CovidTestIdentifierFactory covidTestIdentifierFactory = new CovidTestIdentifierFactoryImpl();

CovidTestIdentifier testIdentifier = covidTestIdentifierFactory.makeCOVIDTestIdentifier(request);
CovidTestIdentifier testIdentifier = covidTestIdentifierFactory.makeCovidTestIdentifier(request);

return testIdentifier.generateRegistrationToken
(request, scheduledExecutor, stopWatch, fake, appSessionService, fakeDelayService, tanService);
return testIdentifier.generateRegistrationToken(
request, scheduledExecutor, stopWatch, fake, appSessionService, fakeDelayService, tanService);
}
}
Original file line number Diff line number Diff line change
@@ -24,6 +24,6 @@

public interface CovidTestIdentifierFactory {

public CovidTestIdentifier makeCOVIDTestIdentifier(RegistrationTokenRequest request);
public CovidTestIdentifier makeCovidTestIdentifier(RegistrationTokenRequest request);

}
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@

public class CovidTestIdentifierFactoryImpl implements CovidTestIdentifierFactory {
@Override
public CovidTestIdentifier makeCOVIDTestIdentifier(RegistrationTokenRequest request) {
public CovidTestIdentifier makeCovidTestIdentifier(RegistrationTokenRequest request) {
switch (request.getKeyType()) {
case GUID:
return new GuidCovidTestIdentifier();
Original file line number Diff line number Diff line change
@@ -20,6 +20,8 @@

package app.coronawarn.verification.factory;

import static java.util.concurrent.TimeUnit.MILLISECONDS;

import app.coronawarn.verification.domain.VerificationTan;
import app.coronawarn.verification.exception.VerificationServerException;
import app.coronawarn.verification.model.RegistrationToken;
@@ -36,7 +38,6 @@
import org.springframework.http.ResponseEntity;
import org.springframework.util.StopWatch;
import org.springframework.web.context.request.async.DeferredResult;
import static java.util.concurrent.TimeUnit.MILLISECONDS;

@RequiredArgsConstructor
@Slf4j