Skip to content

Commit

Permalink
Address code review
Browse files Browse the repository at this point in the history
  • Loading branch information
corona10 committed Aug 30, 2023
1 parent 67e3a54 commit 2e2377f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
10 changes: 7 additions & 3 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -5823,7 +5823,7 @@ AC_ARG_WITH(
AS_CASE([$with_readline],
[editline|edit], [with_readline=edit],
[yes|readline], [with_readline=readline],
[no], [with_readline=default],
[no], [],
[AC_MSG_ERROR([proper usage is --with(out)-readline@<:@=editline|readline|no@:>@])]
)
],
Expand All @@ -5833,9 +5833,10 @@ AC_ARG_WITH(
dnl gh-105323: Need to handle the macOS editline as an alias of readline.
AS_VAR_IF([with_readline], [default], [
AS_CASE([$ac_sys_system/$ac_sys_release],
[Darwin/*], [AC_DEFINE([WITH_APPLE_READLINE], [1]) with_readline=readline],
[with_readline=readline])
])
[Darwin/*], [AC_DEFINE([WITH_APPLE_READLINE])],
[])]
)
AS_VAR_IF([with_readline], [default], [with_readline=readline])

AS_VAR_IF([with_readline], [readline], [
PKG_CHECK_MODULES([LIBREADLINE], [readline], [
Expand Down

0 comments on commit 2e2377f

Please sign in to comment.