Skip to content

Commit

Permalink
pin prettier version because of breaking changes
Browse files Browse the repository at this point in the history
Suddenly, the prettier action started to fail for no aparent reason.
The error message was:

```
Installing prettier...
Checking plugin: prettier-plugin-solidity
Prettifying files...
Files:
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/archive/PersonalInviteOld.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/archive/PersonalInviteOld.t.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/AllowList.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/ContinuousFundraising.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/FeeSettings.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/interfaces/IFeeSettings.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/PersonalInvite.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/PersonalInviteFactory.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/Token.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/contracts/VestingWalletFactory.sol".
docs/deployment.md 59ms
docs/dev_overview.md 33ms
docs/fees.md 27ms
docs/npm_publishing.md 7ms
docs/price.md 31ms
docs/specification.md 114ms
docs/testing.md 15ms
docs/user_overview.md 45ms
docs/using_the_contracts.md 51ms
LICENSE.md 186ms
README.md 45ms
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/script/CheckToken.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/script/DeployCompany.sol".
Error:  No parser could be inferred for file "/home/runner/work/tokenize.it-smart-contracts/tokenize.it-smart-contracts/script/DeployPlatform.s.sol".
script/hardhatVerifyConstructorArguments/ContinuousFundraising.js 52ms
script/hardhatVerifyConstructorArguments/TokenGoerli.js 3ms
script/hardhatVerifyConstructorArguments/TokenMainnet.js 2ms
script/hardhatVerifyConstructorArguments/VestingWallet.js 3ms
```

It appears prettier v3 introduces some breaking changes, so I pinned
version 2.8.8. See creyD/prettier_action#124
  • Loading branch information
malteish committed Aug 17, 2023
1 parent ade5c0d commit 4f23176
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/prettier.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
- main
workflow_dispatch:
branches:
- "**"
- '**'

name: prettier

Expand All @@ -25,3 +25,4 @@ jobs:
# This part is also where you can pass other options, for example:
prettier_options: --write **/*.{sol,md,js}
prettier_plugins: prettier-plugin-solidity
prettier_version: 2.8.8

0 comments on commit 4f23176

Please sign in to comment.