add test for PaymentSplitter #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #187
We are looking for a contract to distribute fees on-chain. Payment splitter can do just that, so we do not have to develop our own smart contract.
PaymentSplitter receives payments, which can then be distributed to multiple payees according to a fixed split. The payout can be triggered by anyone.
If the split or receiver addresses need updating, a new PaymentSplitter must be deployed.
Possible issue: if we want only the beneficiaries to be able to release their own payments, I need to slightly update the contract. If that is not the case, there is no need to touch it, and we can just use it as-is.
This PR only adds one test that I used to make sure I understood the contract.