Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/extend fee settings #190

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Feature/extend fee settings #190

merged 7 commits into from
Oct 19, 2023

Conversation

malteish
Copy link
Collaborator

@malteish malteish commented Sep 25, 2023 •
edited
Loading

Changes

Introduce 2 new feeCollectors to FeeSettings:

  • continuousFundraisingFeeCollector
  • personalInviteFeeCollector
  • feeCollector is now tokenFeeCollector, but for compatibility feeCollector() still works.

This required an update from IFeeSettingsV1 to IFeeSettingsV2. Currently, FeeSettings implements both.

Introduce a higher fee ceiling for ContinuousFundraising

max fee is now 10% for ContinuousFundraising, see decision

@malteish malteish merged commit 55e9baf into develop Oct 19, 2023
@malteish malteish deleted the feature/extendFeeSettings branch October 19, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CJentzsch CJentzsch CJentzsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malteish @CJentzsch