Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change headless service to gRPC and expose 9094 TCP #494
fix: change headless service to gRPC and expose 9094 TCP #494
Changes from 22 commits
dcc7660
d8bdc70
a001e49
b0df50e
e483cd5
84c1331
05b3403
d29022e
8d22e3a
1d830da
e909803
b9efaee
87e6eb4
62c1222
5d9c403
047bd29
3236b34
bd4b07f
970ea28
355af4d
ce177c3
2f421f2
d75baf1
56238b6
a4f1c17
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should inform the user about this breaking chance in CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the CHANGELOG.md to make this clearer. Or do you think we should add a better indication that this may break if users were using the
http-metrics
port for their own usage? Similar to the old PR we have here #169And by breaking - do you mean we should make it to v3 (too much I think?) or a line in the CHANGELOG should be good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. I don't have a strong opinion about it. Technically it should be a major release because it will break if somebody depends on it (somehow).
And to be honest so #169 should have been.
CC: @kd7lxl Do you have an opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just not touch the
http-metrics
port, so that there is no breaking change. Adding gRPC has nothing to do with thehttp-metrics
port.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. Let me update that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!