Set align_queries_with_step to false as default #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardscaueru
force-pushed
the
query_range_align_with_step_set_default_false
branch
6 times, most recently
from
69ae13b to
f1c033a
Compare
nschad
requested changes
Jan 15, 2025
eduardscaueru
force-pushed
the
query_range_align_with_step_set_default_false
branch
from
f1c033a to
37c376a
Compare
nschad
approved these changes
Jan 15, 2025
|
FYI: Looks like our github-actions are too old, I've updated them here: #515 Waiting for review from Tom |
…lign-querier-with-step' is false in the official Cortex docs Signed-off-by: eduardscaueru <[email protected]>
nschad
force-pushed
the
query_range_align_with_step_set_default_false
branch
from
37c376a to
9510e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Set align_queries_with_step to false as default, since the 'querier.align-querier-with-step' is false in the official Cortex docs and Cortex implementation.
Which issue(s) this PR fixes:
Fixes #514
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX],[DEPENDENCY]