Remove unused parameters

Signed-off-by: Charlie Le <[email protected]>

cmd/cortextool/main.go

@@ -38,7 +38,7 @@ func main() {
 	analyseCommand.Register(app)
 	bucketValidateCommand.Register(app)
 
-	app.Command("version", "Get the version of the cortextool CLI").Action(func(k *kingpin.ParseContext) error {
+	app.Command("version", "Get the version of the cortextool CLI").Action(func(_ *kingpin.ParseContext) error {
 		fmt.Print(version.Template)
 		version.CheckLatest()
 

cmd/rules-migrator/main.go

@@ -6,7 +6,7 @@ import (
 	"encoding/base64"
 	"flag"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"log"
 	"strings"
 
@@ -75,7 +75,7 @@ func main() {
 			log.Fatalf("unable to load object, %v", err)
 		}
 
-		data, err := ioutil.ReadAll(reader)
+		data, err := io.ReadAll(reader)
 		if err != nil {
 			log.Fatalf("unable to read object, %v", err)
 		}

pkg/analyse/grafana.go

@@ -153,7 +153,7 @@ func parseQuery(query string, metrics map[string]struct{}) error {
 		return err
 	}
 
-	parser.Inspect(expr, func(node parser.Node, path []parser.Node) error {
+	parser.Inspect(expr, func(node parser.Node, _ []parser.Node) error {
 		if n, ok := node.(*parser.VectorSelector); ok {
 			metrics[n.Name] = struct{}{}
 		}

pkg/analyse/ruler.go

@@ -43,7 +43,7 @@ func ParseMetricsInRuleGroup(mir *MetricsInRuler, group rwrulefmt.RuleGroup, ns
 			continue
 		}
 
-		parser.Inspect(expr, func(node parser.Node, path []parser.Node) error {
+		parser.Inspect(expr, func(node parser.Node, _ []parser.Node) error {
 			if n, ok := node.(*parser.VectorSelector); ok {
 				refMetrics[n.Name] = struct{}{}
 			}

pkg/chunk/gcp/gcs_scanner.go

@@ -1,15 +1,16 @@
 package gcp
 
 import (
-	"cloud.google.com/go/storage"
 	"context"
 	"fmt"
+	"io"
+
+	"cloud.google.com/go/storage"
 	"github.com/cortexproject/cortex/pkg/chunk"
 	"github.com/cortexproject/cortex/pkg/chunk/gcp"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	"google.golang.org/api/iterator"
-	"io"
 
 	chunkTool "github.com/cortexproject/cortex-tools/pkg/chunk"
 )

pkg/chunk/migrate/reader/reader.go

@@ -140,7 +140,7 @@ func (r *Reader) readLoop(ctx context.Context, outChan chan cortex_chunk.Chunk,
 				"shard": req.Prefix})
 
 			logEntry.Infoln("attempting  scan request")
-			err := r.scanner.Scan(ctx, req, func(i cortex_chunk.Chunk) bool {
+			err := r.scanner.Scan(ctx, req, func(_ cortex_chunk.Chunk) bool {
 				// while this does not mean chunk is sent by scanner, this is the closest we can get
 				SentChunks.Inc()
 				return true

pkg/client/alerts.go

@@ -2,10 +2,11 @@ package client
 
 import (
 	"context"
+	"io"
+
 	"github.com/pkg/errors"
 	log "github.com/sirupsen/logrus"
 	"gopkg.in/yaml.v3"
-	"io"
 )
 
 const alertmanagerAPIPath = "/api/v1/alerts"

pkg/client/rules_test.go

@@ -12,7 +12,7 @@ import (
 func TestCortexClient_DeleteRuleGroup(t *testing.T) {
 	requestCh := make(chan *http.Request, 1)
 
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	ts := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
 		requestCh <- r
 	}))
 	defer ts.Close()
@@ -76,7 +76,7 @@ func TestCortexClient_DeleteRuleGroup(t *testing.T) {
 func TestCortexClient_DeleteRuleNamespace(t *testing.T) {
 	requestCh := make(chan *http.Request, 1)
 
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+	ts := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
 		requestCh <- r
 	}))
 	defer ts.Close()

pkg/commands/rules.go

@@ -642,7 +642,7 @@ func (r *RuleCommand) prepare(_ *kingpin.ParseContext) error {
 	}
 
 	// Do not apply the aggregation label to excluded rule groups.
-	applyTo := func(group rwrulefmt.RuleGroup, rule rulefmt.RuleNode) bool {
+	applyTo := func(group rwrulefmt.RuleGroup, _ rulefmt.RuleNode) bool {
 		_, excluded := r.aggregationLabelExcludedRuleGroupsList[group.Name]
 		return !excluded
 	}

pkg/rules/rules.go

@@ -143,7 +143,7 @@ func (r RuleNamespace) AggregateBy(label string, applyTo func(group rwrulefmt.Ru
 // exprNodeInspectorFunc returns a PromQL inspector.
 // It modifies most PromQL expressions to include a given label.
 func exprNodeInspectorFunc(rule rulefmt.RuleNode, label string) func(node parser.Node, path []parser.Node) error {
-	return func(node parser.Node, path []parser.Node) error {
+	return func(node parser.Node, _ []parser.Node) error {
 		var err error
 		switch n := node.(type) {
 		case *parser.AggregateExpr:

pkg/rules/rules_test.go

@@ -176,7 +176,7 @@ func TestAggregateBy(t *testing.T) {
 					},
 				},
 			},
-			applyTo: func(group rwrulefmt.RuleGroup, rule rulefmt.RuleNode) bool {
+			applyTo: func(group rwrulefmt.RuleGroup, _ rulefmt.RuleNode) bool {
 				return group.Name != "CountSkipped"
 			},
 			expectedExpr: []string{`count by(namespace, cluster) (test_series) > 1`, `count by(namespace) (test_series) > 1`},