Refactor Makefile and update versions in Dockerfile #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CharlieTLe
commented
Apr 21, 2024
CharlieTLe
commented
- refactors Makefile to generate Dockerfiles with Dockerfile.template
- updates version of Go to 1.22 and alpine to 3.19.1 in Dockerfiles
- adds new Dockerfiles for sim, blockgen, deserializer, and rules-migrator commands
- update .gitignore to ignore new commands
- refactors Makefile to generate Dockerfiles with Dockerfile.template - updates version of Go to 1.22 and alpine to 3.19.1 in Dockerfiles - adds new Dockerfiles for sim, blockgen, deserializer, and rules-migrator commands - update .gitignore to ignore new commands Signed-off-by: Charlie Le <[email protected]>
friedrichg
reviewed
Apr 23, 2024
CharlieTLe
force-pushed
the
update-dockerfiles-and-refactor-makefile
branch
from
f13ffe5 to
aa418f6
Compare
Signed-off-by: Charlie Le <[email protected]>
CharlieTLe
force-pushed
the
update-dockerfiles-and-refactor-makefile
branch
from
aa418f6 to
1950962
Compare
friedrich-at-adobe
approved these changes
Apr 24, 2024
friedrichg
approved these changes
Apr 24, 2024
friedrichg
pushed a commit
that referenced
this pull request
May 9, 2024
* Refactor Makefile and update versions in Dockerfile - refactors Makefile to generate Dockerfiles with Dockerfile.template - updates version of Go to 1.22 and alpine to 3.19.1 in Dockerfiles - adds new Dockerfiles for sim, blockgen, deserializer, and rules-migrator commands - update .gitignore to ignore new commands Signed-off-by: Charlie Le <[email protected]> * Update changelog Signed-off-by: Charlie Le <[email protected]> --------- Signed-off-by: Charlie Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.