Fix race condition on ingester client metric

Signed-off-by: alanprot <[email protected]>
cortexproject · May 9, 2024 · ada252a · ada252a
1 parent bc4d24c
commit ada252a
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pkg/ingester/client/client.go b/pkg/ingester/client/client.go
@@ -73,10 +73,9 @@ func (c *closableHealthAndIngesterClient) Push(ctx context.Context, in *cortexpb
 
 func (c *closableHealthAndIngesterClient) handlePushRequest(mainFunc func() (*cortexpb.WriteResponse, error)) (*cortexpb.WriteResponse, error) {
 	currentInflight := c.inflightRequests.Inc()
-	c.inflightPushRequests.WithLabelValues(c.addr).Inc()
+	c.inflightPushRequests.WithLabelValues(c.addr).Set(float64(currentInflight))
 	defer func() {
-		c.inflightPushRequests.WithLabelValues(c.addr).Dec()
-		c.inflightRequests.Dec()
+		c.inflightPushRequests.WithLabelValues(c.addr).Set(float64(c.inflightRequests.Dec()))
 	}()
 	if c.maxInflightPushRequests > 0 && currentInflight > c.maxInflightPushRequests {
 		return nil, errTooManyInflightPushRequests