Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building time increased 60s because of node #5877

Closed
friedrichg opened this issue Apr 22, 2024 · 4 comments
Closed

Building time increased 60s because of node #5877

friedrichg opened this issue Apr 22, 2024 · 4 comments

Comments

@friedrichg
Copy link
Member

Describe the bug
Nodesource is punishing us with 60s more build time

 => [3/9] RUN curl -sL https://deb.nodesource.com/setup_14.x | bash -                      48.8s
 => => #                           SCRIPT DEPRECATION WARNING
 => => # ================================================================================
 => => # ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓
 => => # ================================================================================
 => => # TO AVOID THIS WAIT MIGRATE THE SCRIPT
 => => # Continuing in 60 seconds (press Ctrl-C to abort) ...

To Reproduce
Steps to reproduce the behavior:

  1. Run make
  2. see the waiting time in the logs

Expected behavior
There should be no waiting time. We should use something else

Additional Context
The bug is on

RUN curl -sL https://deb.nodesource.com/setup_14.x | bash -

@yeya24
Copy link
Contributor

yeya24 commented Apr 22, 2024

Let's update build image script to use Node 18 instead.

@yeya24
Copy link
Contributor

yeya24 commented Apr 25, 2024

Help wanted. This should be a low hanging fruit.

@Kramer0x0
Copy link
Contributor

I can pick this up if you want to assign to me.

@yeya24
Copy link
Contributor

yeya24 commented Apr 29, 2024

Let's resolve it since #5906 already merged

@yeya24 yeya24 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants