Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading build-image to node 18 #5904

Closed

Conversation

Kramer0x0
Copy link
Contributor

What this PR does:

This fixes the issue where node 14 script was being deprecated and a 60 second window starts. Upgrading to Node 18 version.

Which issue(s) this PR fixes:
#5877

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://cortexmetrics.io/docs/contributing/how-to-update-the-build-image/,

a maintainer needs to build the image using this branch and provide the new image tag.

CHANGELOG.md Outdated
@@ -49,6 +49,7 @@
* [BUGFIX] Cortex: Fix GRPC stream clients not honoring overrides for call options. #5797
* [BUGFIX] Ring DDB: Fix lifecycle for ring counting unhealthy pods as healthy. #5838
* [BUGFIX] Ring DDB: Fix region assignment. #5842
* [CHANGE] Upgrade Dockerfile Node version from 14x to 18x.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this under master / unreleased section? Also please mention the PR number

@Kramer0x0
Copy link
Contributor Author

Will resolve conflicts shortly!

@yeya24
Copy link
Contributor

yeya24 commented Apr 26, 2024

Sorry can you please rebase again? Since we just merged another PR and it caused a conflict

yeya24 and others added 7 commits April 26, 2024 12:30
cortexproject#5901)

* Remove APIEnableRulesBackup config and use Ring.ReplicationFactor instead

Signed-off-by: Emmanuel Lodovice <[email protected]>

* Update changelog

Signed-off-by: Emmanuel Lodovice <[email protected]>

* Update change log

Signed-off-by: Emmanuel Lodovice <[email protected]>

* Consider AZ awareness disabled if only 1 zone is present in list rules

Signed-off-by: Emmanuel Lodovice <[email protected]>

---------

Signed-off-by: Emmanuel Lodovice <[email protected]>
…ts (cortexproject#5892)

* update stats

Signed-off-by: Ben Ye <[email protected]>

* update stats

Signed-off-by: Ben Ye <[email protected]>

* collect store gateway postings touched count and bytes in querier stats

Signed-off-by: Ben Ye <[email protected]>

* changelog

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ryan West <[email protected]>
Signed-off-by: Ryan West <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants