Reduce cardinality on rules backup metrics by counting rules per tenant #5873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Lodovice <[email protected]>
emanlodovice
force-pushed
the
reduce-ruler-backup-metrics-cardinality
branch
from
74f0152 to
61e9772
Compare
|
LGTM |
rapphil
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR address this comment https://github.com/cortexproject/cortex/pull/5782/files#r1543847038 from a recently merged PR.
We replaced the metric
cortex_ruler_backup_rule_groupwhich has the rule_group as label and has value 1 or 0 with the metriccortex_ruler_backup_ruleswhich contains the number of rules the ruler stores in backup for each tenant andcortex_ruler_backup_rule_groupswhich contains the number of rule groups the ruler stores in backup for each tenant. This should reduce the cardinality.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]