Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go version for integration tests #5882

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

friedrichg
Copy link
Member

What this PR does: fix go version for integration tests. Follow up from #5879

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Friedrich Gonzalez <[email protected]>
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 2253e3c into master Apr 23, 2024
16 checks passed
@yeya24 yeya24 deleted the fix-go-version-for-integration-test branch April 23, 2024 16:37
yeya24 pushed a commit to yeya24/cortex that referenced this pull request Apr 23, 2024
yeya24 added a commit to yeya24/cortex that referenced this pull request Apr 23, 2024
yeya24 added a commit to yeya24/cortex that referenced this pull request Apr 24, 2024
Signed-off-by: Ben Ye <[email protected]>

try fixing lint

Signed-off-by: Ben Ye <[email protected]>

try again

Signed-off-by: Ben Ye <[email protected]>
friedrichg added a commit that referenced this pull request Apr 24, 2024
* Upgrade Alpine to 3.18 (#5684)

* Upgrade Alpine to 3.18

Signed-off-by: Daniel Sabsay <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Daniel Sabsay <[email protected]>

---------

Signed-off-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>

* Upgrade to go 1.21.9 (#5879)

* Upgrade to go 1.21.9

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Update changelog and workflows

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Not use minor version for now. Needs more investigation

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Update image again

Signed-off-by: Friedrich Gonzalez <[email protected]>

---------

Signed-off-by: Friedrich Gonzalez <[email protected]>

* fix go version for integration tests (#5882)

Signed-off-by: Friedrich Gonzalez <[email protected]>

* include #5882 to changelog

Signed-off-by: Ben Ye <[email protected]>

try fixing lint

Signed-off-by: Ben Ye <[email protected]>

try again

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Friedrich Gonzalez <[email protected]>
yeya24 added a commit that referenced this pull request Apr 25, 2024
* Cherrypick commits for 1.16.1 (#5885)

* Upgrade Alpine to 3.18 (#5684)

* Upgrade Alpine to 3.18

Signed-off-by: Daniel Sabsay <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Daniel Sabsay <[email protected]>

---------

Signed-off-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>

* Upgrade to go 1.21.9 (#5879)

* Upgrade to go 1.21.9

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Update changelog and workflows

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Not use minor version for now. Needs more investigation

Signed-off-by: Friedrich Gonzalez <[email protected]>

* Update image again

Signed-off-by: Friedrich Gonzalez <[email protected]>

---------

Signed-off-by: Friedrich Gonzalez <[email protected]>

* fix go version for integration tests (#5882)

Signed-off-by: Friedrich Gonzalez <[email protected]>

* include #5882 to changelog

Signed-off-by: Ben Ye <[email protected]>

try fixing lint

Signed-off-by: Ben Ye <[email protected]>

try again

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Friedrich Gonzalez <[email protected]>

* update changelog

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Daniel Sabsay <[email protected]>
Signed-off-by: Friedrich Gonzalez <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Daniel Sabsay <[email protected]>
Co-authored-by: Friedrich Gonzalez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants