-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove APIEnableRulesBackup config and use Ring.ReplicationFactor ins… #5901
Merged
yeya24
merged 4 commits into
cortexproject:master
from
emanlodovice:remove-api-enable-rules-backup
Apr 26, 2024
Merged
Remove APIEnableRulesBackup config and use Ring.ReplicationFactor ins… #5901
yeya24
merged 4 commits into
cortexproject:master
from
emanlodovice:remove-api-enable-rules-backup
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead Signed-off-by: Emmanuel Lodovice <[email protected]>
Signed-off-by: Emmanuel Lodovice <[email protected]>
yeya24
reviewed
Apr 26, 2024
Signed-off-by: Emmanuel Lodovice <[email protected]>
Signed-off-by: Emmanuel Lodovice <[email protected]>
emanlodovice
force-pushed
the
remove-api-enable-rules-backup
branch
from
April 26, 2024 09:21
e8aba16
to
21ace57
Compare
Test failed related to minimize spread token, unrelated but worth taking a look. @alanprot
|
yeya24
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this change. Great work. Thanks @emanlodovice!
Kramer0x0
pushed a commit
to Kramer0x0/cortex
that referenced
this pull request
Apr 26, 2024
cortexproject#5901) * Remove APIEnableRulesBackup config and use Ring.ReplicationFactor instead Signed-off-by: Emmanuel Lodovice <[email protected]> * Update changelog Signed-off-by: Emmanuel Lodovice <[email protected]> * Update change log Signed-off-by: Emmanuel Lodovice <[email protected]> * Consider AZ awareness disabled if only 1 zone is present in list rules Signed-off-by: Emmanuel Lodovice <[email protected]> --------- Signed-off-by: Emmanuel Lodovice <[email protected]>
yeya24
pushed a commit
to yeya24/cortex
that referenced
this pull request
Apr 27, 2024
cortexproject#5901) * Remove APIEnableRulesBackup config and use Ring.ReplicationFactor instead Signed-off-by: Emmanuel Lodovice <[email protected]> * Update changelog Signed-off-by: Emmanuel Lodovice <[email protected]> * Update change log Signed-off-by: Emmanuel Lodovice <[email protected]> * Consider AZ awareness disabled if only 1 zone is present in list rules Signed-off-by: Emmanuel Lodovice <[email protected]> --------- Signed-off-by: Emmanuel Lodovice <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tead
What this PR does:
This PR removes the
-experimental.ruler.api-enable-rules-backup
config because it only makes sense ifruler.ring.replication-factor
is set to a value greater than 1. So instead of having the a dedicated config we just infer that rules backup is enabled ifruler.ring.replication-factor
is greater than 1.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]