Allowing to disabled detailed ring metrics #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
alanprot
requested review from
danielblando and
yeya24
and removed request for
danielblando
danielblando
approved these changes
May 7, 2024
Signed-off-by: alanprot <[email protected]>
yeya24
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Creates a flag to allow disabling the "detailed ring metrics"
The metrics indicate the ownership or token count per ingester. However, since they are generated by the distributor, they can rapidly generate a large number of metrics. (every distributor will emit the same value)
Those metrics are not super useful as they only change when we have a configuration change (number of tokens) or a scale up /down of ingesters (ownership) -> Both of these informations are already on the ring page on the distributor.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]