Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the -etcd.ping-without-stream-allowed parameter #5933

Merged
merged 6 commits into from
May 8, 2024

Conversation

KrisBuytaert
Copy link
Contributor

@KrisBuytaert KrisBuytaert commented May 8, 2024

Adding the -etcd.ping-without-stream-allowed parameter

What this PR does:

This parameter allows the setting of the PermitWithoutStream so it can be disabled (default behaviour is still true).
Allowing to set this Parameter is a solution for

#5897

Which issue(s) this PR fixes:
Fixes #5897

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…ble this etcd connectivity parameter

Signed-off-by: Kris Buytaert <[email protected]>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 8, 2024
Signed-off-by: Kris Buytaert <[email protected]>
@alanprot
Copy link
Member

alanprot commented May 8, 2024

Thanks..LGTM

@alanprot alanprot merged commit 09ea351 into cortexproject:master May 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants