Integration test for native histograms #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieTLe
reviewed
Jun 26, 2024
integration/native_histogram_test.go
Outdated
| c, err = e2ecortex.NewClient("", queryFrontend.HTTPEndpoint(), "", "", "user-1") | ||
| require.NoError(t, err) | ||
|
|
||
| result, err := c.Query(`series_1`, series2Timestamp) |
There was a problem hiding this comment.
Should this be seriesTimetamp?
There was a problem hiding this comment.
It is an instant query and it is still within lookback delta so it can still query series 1. So it doesn't matter here.
CharlieTLe
approved these changes
Jun 27, 2024
yeya24
force-pushed
the
native-histogram-e2e
branch
from
9560153 to
1d97569
Compare
3 tasks
yeya24
force-pushed
the
native-histogram-e2e
branch
from
ad7f080 to
4aa30f6
Compare
|
I have updated the test to also do range query and make sure returned histogram is not nil. |
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
native-histogram-e2e
branch
from
5f6e4c6 to
d5f44c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow up of #6031. This PR adds integration for native histograms.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]