-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Getting Started Improvements #6046
docs: Getting Started Improvements #6046
Conversation
- Enable auth for multi-tenancy. - Load the Cortex dashboards from the cortex-jsonnet repo for the getting-started tutorial. This should allow newcomers to get a better feel for what Cortex is doing. - Configure recording rules, alerting rules, and alertmanager with cortextool. - Add Grafana datasources to showcase multi-tenancy. Signed-off-by: Charlie Le <[email protected]>
c19ac04
to
601bf42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
I am ok repeating cortex-jsonnet dashboards, alerts and rules here in a more readable format.
The only thing I would like to see is a way to do update it here easily.
A makefile target is one option. As simple as:
- download specific cortex-mixin.zip. Ej: https://github.com/cortexproject/cortex-jsonnet/releases/download/1.16.1/cortex-mixin.zip
- unzip it in the right places. ...
Signed-off-by: Charlie Le <[email protected]>
When generating the dashboards, It looks like the dashboards from cortex-mixin.zip has Should we clone the cortex-jsonnet repo to generate the output files? |
Signed-off-by: Charlie Le <[email protected]>
Signed-off-by: Charlie Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the feedback 🙇 . I have only one small nit. For that I created this PR CharlieTLe#5
@@ -0,0 +1,64 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think I prefer we modify mixin.libsonnet.
Signed-off-by: Friedrich Gonzalez <[email protected]>
Use mixin.libsonnet instead of config.libsonnet
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]