Make sure bucket index load failure will not increase if there is context error #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tenxt error Signed-off-by: Alex Le <[email protected]>
alexqyle
force-pushed
the
bucket-index-load-failure
branch
from
a065870 to
299592b
Compare
harry671003
reviewed
Jul 2, 2024
Signed-off-by: Alex Le <[email protected]>
alexqyle
force-pushed
the
bucket-index-load-failure
branch
from
19dd094 to
b2ea947
Compare
alanprot
approved these changes
Jul 3, 2024
friedrichg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Query failure or timeout would cause context got cancelled anytime before loading bucket index. This change should make sure
cortex_bucket_index_load_failures_totalwill not increase if such thing happens.Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]