Add enable delayed compaction #6284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/ingester
storage/blocks
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
Add-enable-delayed-compaction
branch
from
33adefc to
ecca5b8
Compare
|
@yeya24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
-blocks-storage.tsdb.enable-delayed-compactionto compact TSDBs in Ingester with random delay.(Upstream prometheus PR: prometheus/prometheus#12532, Issue: prometheus/prometheus#8278)
Current behavior runs all of TSDB compaction simultaneously for every 2h (chunk range).
The problem is CPU and Disk of Ingesters spike every 2 our.
Periodic resource spike system resources could make capacity planning hard.
To address this concern, the Prometheus added the option for delaying TSDB compaction by adding some random delay.
Adding this option to the Cortex would be useful as the Ingester operates many TSDBs.
So, this PR adds it to Cortex and I expect it spreads system resources usage.
Here is my cortex cluster system resource usage:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]