Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support label_join and label_replace in query fuzz tests #6302

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 2, 2024

What this PR does:

Upgrade promqlsmith to cortexproject/promqlsmith#129 to support label_join and label_replace.

Improved existing TestDisableChunkTrimmingFuzz test case to generate multiple series under a single metric name as well as reducing the generated queries' complexity.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ben Ye <[email protected]>
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 2, 2024
@alanprot alanprot merged commit e31f9c2 into cortexproject:master Nov 2, 2024
16 checks passed
@yeya24 yeya24 deleted the upgrade-promqlsmith-label branch November 4, 2024 21:33
CharlieTLe pushed a commit to CharlieTLe/cortex that referenced this pull request Dec 3, 2024
…ct#6302)

* support label_join and label_replace in query fuzz tests

Signed-off-by: Ben Ye <[email protected]>

* fix lint

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants