Fix race on the string interning #6408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
race-string-intern
branch
2 times, most recently
from
0d1d004 to
bd6b5df
Compare
alanprot
force-pushed
the
race-string-intern
branch
from
bd6b5df to
4d5f5b1
Compare
alanprot
force-pushed
the
race-string-intern
branch
from
4d5f5b1 to
95ee758
Compare
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
race-string-intern
branch
from
95ee758 to
5e86c66
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix Race when the
-ingester.labels-string-interning-enabledexperimental feature is enabled.The race happens as tsdb calls the PostCreation outside the lock (see this) but after the series is already added on the
s.hasheshash. With this, this series is already returned on the GetByHash method and so, we may race with the interning.This change is proposing intern the strings using a LRU cache and so we can stop managing the release of the strings. The LRU ttl is set to be similar to the range blocks interval and so, we should not keep strings in the heap for more time than needed.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]