Create new cortex_querier_codec_response_size histogram to track the size of the encoded Query responses
#6444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
component/querier
type/observability
…QF to Querier Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
instrumented-codec
branch
2 times, most recently
from
3d205b4 to
5b86448
Compare
harry671003
approved these changes
Dec 18, 2024
Signed-off-by: alanprot <[email protected]>
alanprot
force-pushed
the
instrumented-codec
branch
from
5b86448 to
0a52b2e
Compare
yeya24
reviewed
Dec 18, 2024
We also have metric after compression.. but i wanna a metric before compression as this reflects more the memory needed on the QF. |
yeya24
approved these changes
Dec 18, 2024
alanprot
changed the title
cortex_querier_codec_response_size_bucket histogram to track the size of the encoded responses from …cortex_querier_codec_response_size histogram to track the size of the encoded Query responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We already have a similar metric
cortex_querier_response_message_bytes_bucketbut this metric shows the response size after the compression (gzip).This new metric tracks the size of the request before the compression. This can be useful as the responses are decompressed on QF and it can cause OOM errors.
In a future PR we may wanna create an option to limit the size of the responses from Queriers, so we protect QF from OOM.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]