Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose indexheader download and load duration histograms #6445

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 19, 2024

Signed-off-by: Ben Ye [email protected]<!-- Thanks for sending a pull request! Before submitting:

  1. Read our CONTRIBUTING.md guide
  2. Rebase your PR if it gets out of sync with master
    -->

What this PR does:

Added cortex_bucket_store_indexheader_load_duration_seconds and cortex_bucket_store_indexheader_download_duration_seconds metrics for time of downloading and loading index header files.

We already have cortex_bucket_store_block_load_duration_seconds for total time loading an individual block. But these 2 metrics expose more information of the internal steps of loading blocks.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added component/store-gateway type/observability To help know what is going on inside Cortex labels Dec 19, 2024
Signed-off-by: Ben Ye <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 23, 2024
@yeya24 yeya24 merged commit ba6b14a into cortexproject:master Dec 23, 2024
17 checks passed
@yeya24 yeya24 deleted the expose-more-indexheader-metrics branch December 24, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/store-gateway lgtm This PR has been approved by a maintainer size/M type/observability To help know what is going on inside Cortex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants