Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QFE: Fix @ modifier for subquery #6450

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

harry671003
Copy link
Contributor

What this PR does:

  • Fixes @ modifier for sub query
  • When sub queries are split by QFE, currently the @ modifier is not applied. This causes wrong results as the @ modifier will be applied on querier.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth a bugfix changelog

Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
@harry671003 harry671003 changed the title Fix @ modifier for subquery when split QFE: Fix @ modifier for subquery Dec 20, 2024
@yeya24 yeya24 merged commit 5a78608 into cortexproject:master Dec 20, 2024
17 checks passed
@alanprot
Copy link
Member

Probably we have the same problem with the offset modifier? @harry671003 ?

@harry671003
Copy link
Contributor Author

Probably we have the same problem with the offset modifier?

Since offset is applied relative to the timestamp of the step, it shouldn't be a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants