discarded samples per labelset metrics for throttle by labelset #6492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <[email protected]>
alanprot
reviewed
Jan 8, 2025
pkg/distributor/distributor.go
Outdated
| @@ -1048,7 +1064,7 @@ func (d *Distributor) prepareSeriesKeys(ctx context.Context, req *cortexpb.Write | |||
| matchedLabelSetLimits := validation.LimitsPerLabelSetsForSeries(limitsPerLabelSet, cortexpb.FromLabelAdaptersToLabels(validatedSeries.Labels)) | |||
| if len(matchedLabelSetLimits) > 0 && labelSetCounters == nil { | |||
| // TODO: use pool. | |||
| labelSetCounters = make(map[uint64]*samplesLabelSetEntry, len(matchedLabelSetLimits)) | |||
| labelSetCounters = make(map[uint64]*samplesLabelSetEntry, len(limitsPerLabelSet)) | |||
There was a problem hiding this comment.
Is there a reason why now we creating with the limitsPerLabelSet size?
There was a problem hiding this comment.
Umm, I copied over the code I had from last PR and I am a bit lost here.
I think you are right the size should be at max matchedLabelSetLimits. I will update the code.
alanprot
reviewed
Jan 8, 2025
| @@ -1201,6 +1229,8 @@ func (i *Ingester) Push(ctx context.Context, req *cortexpb.WriteRequest) (*corte | |||
|
|
|||
| case errors.As(cause, &errMaxSeriesPerLabelSetLimitExceeded{}): | |||
| perLabelSetSeriesLimitCount++ | |||
| // We only track per labelset discarded samples for throttling by labelset limit. | |||
| reasonCounter.increment(matchedLabelSetLimits, perLabelsetSeriesLimit) | |||
There was a problem hiding this comment.
Even though we are only tracking perLabelsetSeriesLimit, we still wanna have this reasonCounter struct so we can easily add other reasons in the future, right?
Signed-off-by: Ben Ye <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Similar to #6464, but we limited the reason to throttle by max series per labelset only to reduce complexity.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]