default rule stat to rule geom

corybrunson · Dec 30, 2024 · 0c36b1c · 0c36b1c
1 parent fd4ca80
commit 0c36b1c
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/R/stat-rule.r b/R/stat-rule.r
@@ -58,7 +58,7 @@
 #' @example inst/examples/ex-stat-rule-glass.r
 #' @export
 stat_rule <- function(
-    mapping = NULL, data = NULL, geom = "axis", position = "identity",
+    mapping = NULL, data = NULL, geom = "rule", position = "identity",
     fun.lower = "minpp", fun.upper = "maxpp",
     fun.offset = "minabspp",
     fun.args = list(),

diff --git a/R/zzz-biplot-stats.r b/R/zzz-biplot-stats.r
@@ -546,7 +546,7 @@ StatRowsRule <- ggproto(
 stat_rows_rule <- function(
   mapping = NULL,
   data = NULL,
-  geom = "axis",
+  geom = "rule",
   position = "identity",
   fun.lower = "minpp",
   fun.upper = "maxpp",
@@ -596,7 +596,7 @@ StatColsRule <- ggproto(
 stat_cols_rule <- function(
   mapping = NULL,
   data = NULL,
-  geom = "axis",
+  geom = "rule",
   position = "identity",
   fun.lower = "minpp",
   fun.upper = "maxpp",

diff --git a/inst/examples/ex-stat-rule-glass.r b/inst/examples/ex-stat-rule-glass.r
@@ -40,7 +40,7 @@ glass_lda %>%
   ggbiplot() +
   theme_bw() + theme_biplot() +
   geom_rows_point(aes(shape = grouping, alpha = discriminant)) +
-  stat_cols_rule(aes(label = name), color = "#888888", num = 8L,
+  stat_cols_rule(aes(label = name), geom = "axis", color = "#888888", num = 8L,
                  fun.offset = \(x) minabspp(x, p = .1),
                  text_size = 2.5, text_dodge = .025) +
   scale_shape_manual(values = c(16L, 17L, 15L, 18L)) +

diff --git a/man/biplot-stats.Rd b/man/biplot-stats.Rd
diff --git a/man/figures/README-predictive biplot-1.png b/man/figures/README-predictive biplot-1.png
diff --git a/man/stat_rule.Rd b/man/stat_rule.Rd