(#21) check_output text=True needed in Python 3

README.md

@@ -39,6 +39,11 @@ Make sure to:
 
 ## Change Log
 
+### [0.8.0] - 2020.12.18
+#### Fixed:
+  - Fix hotedit invocation in Python 3 (check_output returns bytes) (#21)
+  - This change officially breaks backwards compatibility with Python 2
+
 ### [0.7.6] - 2020.02.26
 #### Changed:
   - The version of mock is no longer strictly specified, allowing higher versions to be used while this package is installed
@@ -97,6 +102,7 @@ Make sure to:
   - 0.4: Initial public usable release
 
 [Crosscap]: https://github.com/corydodt/Crosscap
+[0.8.0]: https://github.com/corydodt/Codado/compare/release-0.7.6...release-0.8.0
 [0.7.6]: https://github.com/corydodt/Codado/compare/release-0.7.4...release-0.7.6
 [0.7.4]: https://github.com/corydodt/Codado/compare/release-0.7.2...release-0.7.4
 [0.7.2]: https://github.com/corydodt/Codado/compare/release-0.7.0...release-0.7.2

codado/hotedit.py

@@ -44,7 +44,8 @@ def determine_editor(fallback=EDITOR_FALLBACK):
     If fallback=None, and none of these is a usable editor, raise OSError
     """
     try:
-        ret = subprocess.check_output(shlex.split('git config core.editor'))
+        ret = subprocess.check_output(shlex.split('git config core.editor'),
+                text=True)
         return ret.strip()
     except subprocess.CalledProcessError:
         "git config core.editor didn't work, falling back to environment"

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup, find_packages
 
 
-__version__ = '0.7.6'
+__version__ = '0.8.0'
 
 
 cfg = dict(

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py27,py3
+envlist = py3
 
 [testenv]
 commands = pytest --cov-fail-under=100 -vv