add tstr support for pre_image_content_type #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: steve lasker <[email protected]>
SteveLasker
changed the title
OR13
reviewed
Oct 29, 2024
henkbirkholz
reviewed
Dec 3, 2024
henkbirkholz
reviewed
Dec 3, 2024
|
Agreed to expand to include tstr, and change int to unit, including 16 typ |
Co-authored-by: Henk Birkholz <[email protected]>
henkbirkholz
reviewed
Dec 3, 2024
Co-authored-by: Henk Birkholz <[email protected]>
henkbirkholz
reviewed
Dec 3, 2024
Co-authored-by: Henk Birkholz <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: steve lasker <[email protected]>
|
Changes from the meeting today are completed |
OR13
approved these changes
Dec 4, 2024
OR13
reviewed
Dec 4, 2024
draft-ietf-cose-hash-envelope.md
Outdated
| @@ -181,17 +181,19 @@ IANA is requested to add the following entries to the [COSE Header Algorithm Par | |||
|
|
|||
| - Name: payload_hash_alg | |||
| - Label: TBD_1 | |||
| - Value type: int | |||
| - Value type: uint | |||
There was a problem hiding this comment.
Suggested change
| - Value type: uint | |
| - Value type: int |
See the negative numbers here: https://www.iana.org/assignments/cose/cose.xhtml#algorithms
For example -16 (sha256) is an int, not a uint.
There was a problem hiding this comment.
Why was this marked as resolved? Seems to be a uint for payload_hash_alg. Did I miss something?
There was a problem hiding this comment.
Because it was merged, did you want something different? 🤷
OR13
requested changes
Dec 4, 2024
Co-authored-by: Orie Steele <[email protected]>
OR13
approved these changes
Dec 6, 2024
OR13
reviewed
Dec 6, 2024
Co-authored-by: Orie Steele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes pre_image_content_type consistent with typ: https://www.rfc-editor.org/rfc/rfc9596.html#section-1-2