Reduce horizon and sky jitter #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carifio24
changed the title
|
So it turns out there is still some jitteriness, but I had to be zoomed in about 10 levels in order to see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the horizon and sky jitters. This is accomplished by constructing these via the WWT graphics primitives directly, rather than using annotations that we update on an interval. I have some ideas on how to extract this into general toolkit functionality, but for this story I've just injected the drawing directly into the render loop. Overall, this new system has the benefit that we don't need to worry at all about managing updating the horizon/sky to deal with location or time changes - it will just automatically do what we want it to. This also means that we can get rid of our
Annotation2class.