Updates to WWT sizing during tour on phones #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the display of the tour for devices with a low W:H aspect ratio (that is, tall), like phones. The approach here is that when the tour is playing on a tall device, we keep the WWT component full-width and shrink the height so that the aspect ratio is 4:3, which is the "safe zone" from the WWT tour editor. If the aspect ratio is > 4/3, we do nothing.
For devices with aspect ratios 0.75 <= a.r. < 4/3 in particular, I think this feels like the natural thing to do. If we think that the font size is too small on taller devices (a.r. < 0.75), what we can instead do is rotate everything and force the display into a landscape-style mode. @patudom let me know what you think is the better approach.