Merge pull request #143 from Carifio24/global-setup-teardown-students

Use global setup/teardown of test database, add student endpoint tests

.github/workflows/main.yml

@@ -32,10 +32,10 @@ jobs:
 
       - name: Test
         # This is just the default settings for GH Actions MySQL
-        # Nothing secret here aside from the hashed API key
+        # Nothing secret here aside from the API key
         env:
           DB_TEST_HOSTNAME: 127.0.0.1
           DB_TEST_USERNAME: root
           DB_TEST_PASSWORD: root
-          HASHED_API_KEY: ${{ secrets.HASHED_API_KEY }}
+          CDS_API_KEY: TEST_API_KEY
         run: npm run test

jest.config.ts

@@ -6,9 +6,15 @@ const config: Config = {
   preset: "ts-jest",
   testEnvironment: "node",
   coveragePathIgnorePatterns: [
-    "/node_modules/",
-    "/dist",
-  ]
+    "./node_modules/",
+    "./dist/",
+  ],
+  testPathIgnorePatterns: [
+    "./node_modules/",
+    "./dist/",
+  ],
+  globalSetup: "./tests/setup.ts",
+  globalTeardown: "./tests/teardown.ts"
 };
 
 export default config;

src/authorization.ts

@@ -6,13 +6,20 @@ const HASHER = new SHA3(256);
 
 const validKeys = new Map<string, APIKey>();
 
+export function hashAPIKey(key: string): string {
+  HASHER.reset();
+  HASHER.update(key);
+  const hashed = HASHER.digest("hex");
+  HASHER.reset();
+  return hashed;
+}
+
 export async function getAPIKey(key: string): Promise<APIKey | null> {
   const cachedKey = validKeys.get(key);
   if (cachedKey !== undefined) {
     return cachedKey;
   }
-  HASHER.update(key);
-  const hashedKey = HASHER.digest("hex");
+  const hashedKey = hashAPIKey(key);
   const apiKey = await APIKey.findOne({ where: { hashed_key: hashedKey } });
   HASHER.reset();
   if (apiKey !== null) {

src/database.ts

@@ -253,7 +253,7 @@ export const SignUpStudentSchema = S.struct({
 export type SignUpStudentOptions = S.Schema.To<typeof SignUpStudentSchema>;
 
 export async function signUpStudent(options: SignUpStudentOptions): Promise<SignUpResult> {
-  
+
   const encryptedPassword = encryptPassword(options.password);
 
   let validCode;

src/models/student.ts

@@ -121,7 +121,7 @@ export function initializeStudentModel(sequelize: Sequelize) {
       },
       {
         unique: true,
-        fields: ["verificationCode"]
+        fields: ["verification_code"]
       }
     ]
   });

src/request_results.ts

@@ -65,7 +65,7 @@ export namespace SignUpResult {
   export function statusCode(result: SignUpResult): number {
     switch (result) {
       case SignUpResult.Ok:
-        return 200;
+        return 201;
       case SignUpResult.EmailExists:
         return 409;
       case SignUpResult.BadRequest: