-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to item creation #17
Conversation
I've also now updated this to allow a teacher to set whether a class will be asynchronous, which was enabled via the API endpoint in cosmicds/cds-api#153. |
You could use the base |
@nmearl Yeah, that's probably the way to go, particularly for the error state stuff. I'll update that, and then the computed value that allows submitting can be more robust too. |
@nmearl I did something similar to what you had done with the |
This PR makes a few changes related to adding new students/educators/classes:
/create
endpoints (note that the old ones still work fine)A couple notes:
InputInt
and thus the styling is somewhat different. I wasn't able to find a simple way to make the styling match the other two input widgets, but I'll come back to that in the future.InputInt
is (IMO) a bit unintuitive. If the user enters something invalid, the associated value from the widget just stays as whatever it was before. So if I start with an expected class size of 20, then put in, say, "42.7", then theexpected_size
value is still 20, which will get passed to the database. Also, AFAICT, there's no way to access whether the widget input is in an error state, so I wasn't able to hook a check for that into the button-disable computed.