Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore current class data from all data #687

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Ignore current class data from all data #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hubbleds/pages/05-class-results-uncertainty/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def glue_setup() -> Tuple[JupyterApplication, Dict[str, PlotlyBaseView]]:
student_ids.set(ids)
measurements.set(class_measurements)

all_measurements, student_summaries, class_summaries = LOCAL_API.get_all_data(LOCAL_STATE)
all_measurements, student_summaries, class_summaries = LOCAL_API.get_all_data(GLOBAL_STATE, LOCAL_STATE)
all_meas = Ref(LOCAL_STATE.fields.all_measurements)
all_stu_summaries = Ref(LOCAL_STATE.fields.student_summaries)
all_cls_summaries = Ref(LOCAL_STATE.fields.class_summaries)
Expand Down
4 changes: 3 additions & 1 deletion src/hubbleds/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from cosmicds.state import GlobalState, BaseState, GLOBAL_STATE
from solara import Reactive
from solara.toestand import Ref
from functools import cached_property
from cosmicds.logger import setup_logger
from typing import List

Expand Down Expand Up @@ -328,9 +327,12 @@ def get_class_measurements(

def get_all_data(
self,
global_state: Reactive[GlobalState],
local_state: Reactive[LocalState],
) -> tuple[list[StudentMeasurement], list[StudentSummary], list[ClassSummary]]:
url = f"{self.API_URL}/{local_state.value.story_id}/all-data?minimal=True"
if global_state.value.classroom.class_info is not None:
url += f"&class_id={global_state.value.classroom.class_info['id']}"
r = self.request_session.get(url)
res_json = r.json()

Expand Down