feat(x/distribution): panic on set community pool

x/distribution/types/fee_pool.go

@@ -20,8 +20,8 @@ func (f FeePool) ValidateGenesis() error {
 		return fmt.Errorf("negative DecimalPool in distribution fee pool, is %v", f.DecimalPool)
 	}
 
-	if f.CommunityPool.IsAnyNegative() { // TODO(@julienrbrt) in v0.53, panic if the community pool is set
-		return fmt.Errorf("negative CommunityPool in distribution fee pool, is %v", f.CommunityPool)
+	if !f.CommunityPool.IsZero() {
+		panic(fmt.Sprintf("CommunityPool must be zero in distribution fee pool as it should be specified in protocolpool, current value: %v", f.CommunityPool))
 	}
 
 	return nil

x/distribution/types/fee_pool_test.go

@@ -12,12 +12,55 @@ import (
 )
 
 func TestValidateGenesis(t *testing.T) {
-	fp := types.InitialFeePool()
-	require.Nil(t, fp.ValidateGenesis())
+	testCases := []struct {
+		name        string
+		feePool     types.FeePool
+		shouldPanic bool
+	}{
+		{
+			name: "valid fee pool",
+			feePool: types.FeePool{
+				DecimalPool:   sdk.DecCoins{},
+				CommunityPool: sdk.DecCoins{},
+			},
+			shouldPanic: false,
+		},
+		{
+			name: "negative decimal pool",
+			feePool: types.FeePool{
+				DecimalPool: sdk.DecCoins{
+					sdk.DecCoin{Denom: "stake", Amount: sdk.NewDec(-1)},
+				},
+				CommunityPool: sdk.DecCoins{},
+			},
+			shouldPanic: false,
+		},
+		{
+			name: "non-zero community pool",
+			feePool: types.FeePool{
+				DecimalPool: sdk.DecCoins{},
+				CommunityPool: sdk.DecCoins{
+					sdk.DecCoin{Denom: "stake", Amount: sdk.NewDec(1)},
+				},
+			},
+			shouldPanic: true,
+		},
+	}
 
-	fp2 := types.FeePool{CommunityPool: sdk.DecCoins{{Denom: "stake", Amount: math.LegacyNewDec(-1)}}}
-	require.NotNil(t, fp2.ValidateGenesis())
-
-	fp3 := types.FeePool{DecimalPool: sdk.DecCoins{{Denom: "stake", Amount: math.LegacyNewDec(-1)}}}
-	require.NotNil(t, fp3.ValidateGenesis())
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			if tc.shouldPanic {
+				require.Panics(t, func() {
+					tc.feePool.ValidateGenesis()
+				}, "expected ValidateGenesis to panic with non-zero community pool")
+			} else {
+				err := tc.feePool.ValidateGenesis()
+				if tc.feePool.DecimalPool.IsAnyNegative() {
+					require.Error(t, err)
+				} else {
+					require.NoError(t, err)
+				}
+			}
+		})
+	}
 }