Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove update warning #2717

Closed
wants to merge 1 commit into from
Closed

docs: remove update warning #2717

wants to merge 1 commit into from

Conversation

rootulp
Copy link
Contributor

@rootulp rootulp commented Sep 7, 2023

Description

Cosmos Hub is already at block 16904634 which exceeds the height mentioned in this upgrade warning.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct docs: prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct docs: prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR only changes documentation
  • Reviewed content for consistency
  • Reviewed content for thoroughness
  • Reviewed content for spelling and grammar
  • Tested instructions (if applicable)

Cosmos Hub is already at block [16904634](https://www.mintscan.io/cosmos/blocks/16904634) which exceeds the height mentioned in this upgrade warning.
Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think in the past we kept this warning around until the next release - maybe it's worth changing that to avoid confusion. We could alternatively make it easier to immediately see this is old info by giving the estimated date next to the block height, wdyt @mmulji-ic @mpoke?

@mmulji-ic
Copy link
Contributor

Hi @rootulp we've updated the messaging for the upcoming v12 release. Please see #2718 . Therefore closing as no longer required.

@mmulji-ic mmulji-ic closed this Sep 10, 2023
@mmulji-ic
Copy link
Contributor

Thanks for the contribution! I think in the past we kept this warning around until the next release - maybe it's worth changing that to avoid confusion. We could alternatively make it easier to immediately see this is old info by giving the estimated date next to the block height, wdyt @mmulji-ic @mpoke?

Thanks @p-offtermatt for the suggestion, will definately take a look at this when moving to the new platform.

@rootulp rootulp deleted the patch-3 branch September 11, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants